Create Small PR's
Workflow Habit
The golden rule is that each Pull Request should change less than 200 lines of code.
A pull request is a proposal to merge a set of changes from one branch into another. In a pull request, collaborators can review and discuss the proposed set of changes before they integrate the changes into the main codebase.
Rule of Thumb
- Less than 200 lines.
- A PR Review should last less than 1h 30m
Benefits of Smaller PR's
- Better Testing: Since the code and components changed are smaller, we can put more energy in testing properly each component and change and not the whole app.
- Easier Debugging: Debugging small changes is like finding a typo; debugging big changes is like proofreading an encyclopedia.
- Phased Feature Deployment: We need to taste everything before creating a five-course meal.
Each PR should adhere to the
Single Responsibility Principle.